search

silverstripe / webpack-config

Reusable webpack bundle declarations for Silverstripe modules
BSD 3-Clause "New" or "Revised" License
16 stars 9 forks source link

Update config to be compatible with Webpack 4 #34

Closed scott1702 closed 1 year ago

scott1702 commented 5 years ago

The JS seems to build fine but the CSS fails as extract-text-webpack-plugin is deprecated for Webpack 4.

See https://github.com/webpack-contrib/extract-text-webpack-plugin#usage

⚠️ Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead.

maxime-rainville commented 5 years ago

We're still on webpack 2 and I don't think we have any urgency to upgrade to webpack 4 any time soon.

Is this holding you back in some way?

scott1702 commented 5 years ago

It's not blocking, it just means I'm restricted to using webpack 2 in modules where I want to take advantage of silverstripe/webpack-config.

maxime-rainville commented 5 years ago

I'm not sure it would be possible to develop a CMS module that uses a webpack version different from the silverstripe/admin one.

We're not committed to any specific timeframe in terms of webpack upgrade, but last time we had a discussion about it, our thinking was that it might be a SilverStripe 5 thing.

GuySartorelli commented 1 year ago

We're doing this as part of CMS 5. Closing in favour of https://github.com/silverstripe/silverstripe-admin/issues/1312