silverstripe / webpack-config

Reusable webpack bundle declarations for Silverstripe modules
BSD 3-Clause "New" or "Revised" License
16 stars 9 forks source link

FIX Fix devtool error and remove comments in prod #54

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

Webpack complains and won't build in production mode because devtool is set to an empty string (which used to be acceptable). This has to be false now.

docs: https://webpack.js.org/configuration/devtool/

I've also re-removed comments, which were being included by default against my expectations. Having no comments is the behaviour for the CMS 4 version, so this just fixes a regression where that wasn't happening.

NOTE

After this is merged, I need to create a new 2.0.0-alpha2 tag, re-release on npm, and run yarn install on all the related PRs so they're all using this new tag.

Parent issue