sass-lint was abandoned 5 years ago

emteknetnz commented 6 months ago

We have an ancient version of sass-lint in @silverstripe/webpack-config which triggers dependabot alerts due to some of its own dependencies, which is annoying because it's only a dev dependency so there's no risk to production sites. sass-lint was abandoned 5 years ago, we're already on the latest version of it

We should migrate to something else, probably stylelint

Acceptance criteria

CMS 5 webpack config is updated to use a supported library to lint its stylesheets.
CMS 5 eslint config is updated to use a supported library to lint its stylesheets.
CMS 5 supported modules are updated to use the latest version of our cms 5 webpackconfig and eslint config.
Any linting change are addressed to make sure the builds are green

PRs

NEW PRs

Additional task

https://github.com/silverstripe/.github/issues/228

Note

Disabled rules were excluded according to the principle that the more errors, the greater the likelihood that this rule was not previously supported in the module. But they still require review in each module.

maxime-rainville commented 5 months ago

Random questions:

I'm assuming this can be done in a minor since those are dev dependencies?
Do we know why this wasn't flag in our CMS 5 dependency upgrades?

emteknetnz commented 5 months ago

It's only dev dependencies so I think it could probably be done in a patch
I don't know why it wasn't flagged in CMS 5 dep upgrades

maxime-rainville commented 5 months ago

Guy says: We did catch it, but decided it didn't matter. We're just fixing this now to shut up the dependabot alerts.

GuySartorelli commented 5 months ago

@sabina-talipova Some PRs are failing the JS CI run (I suspect most if not all of them are just slight copy/paste errors in the package.json scripts) - but a lot of them have code being ignored which I didn't expect. I haven't commented on all of them, we can discuss them all together in https://github.com/silverstripe/silverstripe-elemental-bannerblock/pull/141#discussion_r1580185222

GuySartorelli commented 5 months ago

PRs merged

sabina-talipova commented 5 months ago

I reopen it, since I missed some modules.

emteknetnz commented 5 months ago

All merged and merged-up

silverstripe / webpack-config