silverstripeltd / silverstripe-discoverer

Service agnostic abstraction of search querying requirements
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Add generic list types #19

Closed Cambis closed 3 weeks ago

Cambis commented 4 weeks ago

Is your feature request related to a problem? Please describe

Some of the list like properties have typehints such as Facets|Facet[], while these are helpful I think it would be more beneficial to use the generic types such as ArrayList<Facet>.

Thanks for the module, I think its great ❤️

Describe the solution you'd like

Updating the list types to use generic ones provided in Silverstripe 5.2

Describe alternatives you've considered

The current alternative is to leave as is.

Additional context

This would require bumping the minimum silverstripe/framework to 5.2