search

silverwind / droppy

**ARCHIVED** Self-hosted file storage
BSD 2-Clause "Simplified" License
1.62k stars 195 forks source link

add confirmation message when delete is clicked #395

Open Whiterid opened 4 years ago

Whiterid commented 4 years ago

Issue: Delete button is really dangerous #391

mathematicalmichael commented 4 years ago

would love to see this merged cuz... agreed. no confirmation is a bit dangerous.

mattthhdp commented 4 years ago

+1

mathematicalmichael commented 4 years ago

hey. so, I got @Whiterid's code built using npm/node installed locally on an x86_64 ubuntu 18.04 machine and was running it successfully off a mounted exfat drive. I've never built something in node before so it was a bit of a trick to figure out how to get all the dependencies installed on my machine, but it wasn't too hard to figure out. I used that build to create a new docker imags no problem

I then got a raspi 4B+ (armv7) and copied the resulting repo (dist and some other such build files that aren't tracked) over to the pi. I swapped the header in the Dockerfile to be arm32v7/node and successfully built the docker image with this PR's contribution and can confirm it works flawlessly on the raspberry pi. (all that is to say I didn't need node installed on the pi).

For anyone else coming by... you can avoid building by pulling my docker images, here are the resulting paths I pushed to: mathematicalmichael/droppy:x86 (latest) mathematicalmichael/droppy:arm32v7 (pi4)

thank you so much @Whiterid !!!

mathematicalmichael commented 4 years ago

also, despite the README saying that silverwind/armhf-droppy supports ARMv7, I found that I couldn't get it working on the pi 4. I got it running and logged in, but there was a perpetual loading screen on the homepage after login. I would suggest building from the arm32v7/node base if you're shooting for the 4. perhaps the arm32v6 base would support the older models.

EDIT: looks like the perpetual loading screen was due to Safari issues, like #340 #248 perhaps. Avoided by using full IP instead of local domain name. I just got droppy built on the pi zero (incredibly there was enough memory), and can now confirm that all three flavors of this PR are functional and accessible (through firefox)!!!

The arm32v6/node docker image was indeed the correct one for the pi zero architecture. uploaded to mathematicalmichael/droppy:arm32v6 (pi/zero)

tobimichael96 commented 4 years ago

@silverwind pinging you because this adds value to the project and the delete button is really scarry.

Whiterid commented 4 years ago

Hi @mathematicalmichael !

I can't pull your docker image. i try: docker pull mathematicalmichael/droppy

I got this message: Using default tag: latest Error response from daemon: manifest for mathematicalmichael/droppy:latest not found

i'm on linux debian 9.

Ty for your response. And ty to your job too.

mathematicalmichael commented 4 years ago

@Whiterid oh that's my bad https://hub.docker.com/r/mathematicalmichael/droppy/tags at this time it looks like I only pushed my ARM images. let me go ahead and push the x86/latest one. apologies.

all props belongs to you for doing this PR. I just made sure it built cross-platform. Still weird that Safari doesn't play nice with it but oh well.

Whiterid commented 4 years ago

@mathematicalmichael you rocks !

mathematicalmichael commented 4 years ago

@silverwind any thoughts about the confirmation for delete option??

Brazier85 commented 4 years ago

Please add this function. Without it's way to dangerous to use droppy on a prod system.