silverwind / droppy

**ARCHIVED** Self-hosted file storage
BSD 2-Clause "Simplified" License
1.62k stars 195 forks source link

Remove VOLUME from Dockerfile #436

Open Coobik opened 4 years ago

Coobik commented 4 years ago

Hi silverwind,

it would be great if you removed VOLUME from Dockerfile. this directive is confusing. Currently there is no way of removing the volumes declared in base images. So if one derives another docker image from your image, the volumes are still created. If not mounted explicitly by docker run, docker creates them implicitly as anonymous ones under /mnt/sda1/var/lib/docker/volumes/ Not only they stay there until removed with docker volume prune, but there are huge permissions problems for non root users when try to access directories that are declared as volumes - chown and chmod do not help here.

so could you please remove VOLUME from your Dockerfile thanks!

PS your dockerfile and start script and build in a way that it's impossible to start a container under non root user