silverwind / idTip

WoW Addon: Adds IDs to the ingame tooltips
BSD 2-Clause "Simplified" License
41 stars 32 forks source link

Error in 7.2 #29

Closed Stanzilla closed 7 years ago

Stanzilla commented 7 years ago

When opening the artifact window the following error occurs:

69x idTip\idTip-7.0.4.lua:31: attempt to concatenate local 'id' (a table value)
idTip\idTip-7.0.4.lua:31: in function <idTip\idTip.lua:19>
idTip\idTip-7.0.4.lua:89: in function <idTip\idTip.lua:85>
[C]: in function `SetArtifactPowerByID'
...Blizzard_ArtifactUI\Blizzard_ArtifactPowerButton.lua:52: in function <...Blizzard_ArtifactUI\Blizzard_ArtifactPowerButton.lua:44>

Locals:
tooltip = GameTooltip {
 0 = <userdata>
 SetCurrencyByID = <function> defined =[C]:-1
 SetSpellBookItem = <function> defined =[C]:-1
 SetCurrencyToken = <function> defined =[C]:-1
 SetGuildBankItem = <function> defined =[C]:-1
 SetVoidItem = <function> defined =[C]:-1
 SetVoidDepositItem = <function> defined =[C]:-1
 SetOwner = <function> defined =[C]:-1
 SetArtifactPowerByID = <function> defined =[C]:-1
 comparing = false
 isModified = false
 Show = <function> defined @TipTac\core.lua:920
 SetUnitDebuff = <function> defined =[C]:-1
 SetItemByID = <function> defined =[C]:-1
 SetQuestItem = <function> defined =[C]:-1
 FadeOut = <function> defined @TipTac\core.lua:906
 numMoneyFrames = 1
 SetRecipeReagentItem = <function> defined =[C]:-1
 shoppingTooltips = <table> {
 }
 SetCurrencyTokenByID = <function> defined =[C]:-1
 SetQuestLogItem = <function> defined =[C]:-1
 SetBackpackToken = <function> defined =[C]:-1
 SetUnitBuff = <function> defined =[C]:-1
 SetSpellByID = <function> defined =[C]:-1
 SetIconTextureAndText = <function> defined @TipTacItemRef\core.lua:53
 ttIcon = <unnamed> {
 }
 textLeft = <table> {
 }
 updateTooltip = 0.2
 SetInventoryItem = <function> defined =[C]:-1
 ttCount = <unnamed> {
 }
 hasMoney = 1
 SetUnitAura = <function> defined =[C]:-1
 SetBagItem = <function> defined =[C]:-1
 needsReset = true
 SetAction = <function> defined =[C]:-1
 SetVoidWithdrawalItem = <function> defined =[C]:-1
 SetHyperlink = <function> defined =[C]:-1
 SetRecipeResultItem = <function> defined =[C]:-1
}
id = <table> {
 prereqsMet = true
 cost = 2440000
 bonusRanks = 0
 maxRank = 1
 position = <table> {
 }
 isFinal = false
 numMaxRankBonusFromTier = 0
 tier = 1
 isGoldMedal = false
 isStart = false
 currentRank = 1
 spellID = 194026
}
type = "SpellID:"
found = false
(*temporary) = <function> defined =[C]:-1
(*temporary) = GameTooltip {
 0 = <userdata>
 SetCurrencyByID = <function> defined =[C]:-1
 SetSpellBookItem = <function> defined =[C]:-1
 SetCurrencyToken = <function> defined =[C]:-1
 SetGuildBankItem = <function> defined =[C]:-1
 SetVoidItem = <function> defined =[C]:-1
 SetVoidDepositItem = <function> defined =[C]:-1
 SetOwner = <function> defined =[C]:-1
 SetArtifactPowerByID = <function> defined =[C]:-1
 comparing = false
 isModified = false
 Show = <function> defined @TipTac\core.lua:920
 SetUnitDebuff = <function> defined =[C]:-1
 SetItemByID = <function> defined =[C]:-1
 SetQuestItem = <function> defined =[C]:-1
 FadeOut = <function> defined @TipTac\core.lua:906
 numMoneyFrames = 1
 SetRecipeReagentItem = <function> defined =[C]:-1
 shoppingTooltips = <table> {
 }
 SetCurrencyTokenByID = <function> defined =[C]:-1
 SetQuestLogItem = <function> defined =[C]:-1
 SetBackpackToken = <function> defined =[C]:-1
 SetUnitBuff = <function> defined =[C]:-1
 SetSpellByID = <function> defined =[C]:-1
 SetIconTextureAndText = <function> defined @TipTacItemRef\core.lua:53
 ttIcon = <unnamed> {
 }
 textLeft = <table> {
 }
 updateTooltip = 0.2
 SetInventoryItem = <function> defined =[C]:-1
 ttCount = <unnamed> {
 }
 hasMoney = 1
 SetUnitAura = <function> defined =[C]:-1
 SetBagItem = <function> defined =[C]:-1
 needsReset = true
 SetAction = <function> defined =[C]:-1
 SetVoidWithdrawalItem = <function> defined =[C]:-1
 SetHyperlink = <function> defined =[C]:-1
 SetRecipeResultItem = <function> defined =[C]:-1
}
(*temporary) = "SpellID:"
(*temporary) = "|cffffffff"
(*temporary) = <table> {
 prereqsMet = true
 cost = 2440000
 bonusRanks = 0
 maxRank = 1
 position = <table> {
 }
 isFinal = false
 numMaxRankBonusFromTier = 0
 tier = 1
 isGoldMedal = false
 isStart = false
 currentRank = 1
 spellID = 194026
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = GameTooltipTextLeft15 {
 0 = <userdata>
}
(*temporary) = "attempt to concatenate local 'id' (a table value)"
silverwind commented 7 years ago

Thanks for letting me know. I'll try to fix it once this patch hits live servers.

Stanzilla commented 7 years ago

Thank you :) That will be tomorrow this week btw.

silverwind commented 7 years ago

Pushed a fix based on https://github.com/Gethe/wow-ui-source/commit/c25fd83215d0045e937c48f8d68c58466597d84f in https://github.com/silverwind/idTip/commit/53d3bbacab400978ba6435cc8f63fc602e65e5d7.

I can't test it because I don't have a character with an artifact. If you could verify, that'd be great.

silverwind commented 7 years ago

And pushed 7.0.5 with it as I'm pretty confident the fix should work.

Stanzilla commented 7 years ago

Yup, can confirm, Works nice. Thank you!