silverwind / idTip

WoW Addon: Adds IDs to the ingame tooltips
BSD 2-Clause "Simplified" License
41 stars 32 forks source link

Dragonflight Beta / PTR 10.0 error #81

Closed Voxxel closed 1 year ago

Voxxel commented 2 years ago

The addon fails to display 99% of the spell/npc/item/whatever IDs in DF Beta / 10.0 PTR. The only "platform" where it can display the IDs are the Spellbook and the Mounts page - at least what I found so far.

Caught this LUA error in the current DF Beta version (v10.0.45779):

1x [ADDON_ACTION_BLOCKED] AddOn 'idTip' tried to call the protected function 'SubmitBug()'.
[string "@Interface/AddOns/!BugGrabber/BugGrabber.lua"]:480: in function <Interface/AddOns/!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `SubmitBug'
[string "@Interface/AddOns/Blizzard_PTRFeedback/Blizzard_PTRFeedback_Frames.lua"]:769: in function `SubmitIssueReport'
[string "@Interface/AddOns/Blizzard_PTRFeedback/Blizzard_PTRFeedback.lua"]:621: in function `func'
[string "@Interface/AddOns/Blizzard_PTRFeedback/Blizzard_PTRFeedback.lua"]:494: in function `TriggerEvent'
[string "@Interface/AddOns/Blizzard_PTRFeedback/Blizzard_PTRFeedback_Events.lua"]:87: in function `eventFunction'
[string "@Interface/AddOns/Blizzard_PTRFeedback/Blizzard_PTRFeedback_Events.lua"]:264: in function <...Blizzard_PTRFeedback/Blizzard_PTRFeedback_Events.lua:260>
5x Interface/AddOns/idTip/idTip.lua:144: hooksecurefunc(): SpellButton_OnEnter is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@Interface/AddOns/idTip/idTip.lua"]:144: in main chunk

Locals:
yoshimo commented 2 years ago

Tainting the ptr feedback interface happens all the time and can mostly be ignored.

Voxxel commented 2 years ago

I don't know what does that mean but a quick fix would be pretty nice to get back the tooltip IDs.

Voxxel commented 2 years ago

Oh, I see now what you're talking about, it's in the first error message that isn't related. Sorry but most of these lua bugs doesn't tell too much for me. But does that mean the second bug may be related to the addon's general failure in 10.0? Since I didn't receiveany other lua errors related to IDTip so far.

yoshimo commented 2 years ago

The second error is a concern. Functions change, tooltips change and we need to adjust the addon for that.

Voxxel commented 2 years ago

Do you see any chance of a fix in the near future? Or it's rooted deeper than just to apply a hotfix? Afaik, 10.0 is on the PTR too if no DF beta access.

yoshimo commented 2 years ago

Do you see any chance of a fix in the near future? Or it's rooted deeper than just to apply a hotfix? Afaik, 10.0 is on the PTR too if no DF beta access.

yes: https://github.com/ItsJustMeChris/idTip/tree/beta or #80

Voxxel commented 2 years ago

The Chris' version works very well in the Beta, thank you for pointing me out! :)

Voxxel commented 2 years ago

No "Issues" tab on Chris' repo so I post it here: The DF Beta received a new update to 10.0.2.45969 and your fixed idTip went broken again for some instances, such as NPC IDs on mouseover, Spellbook spell IDs, Quest log panel IDs, most of item IDs - on Character page/Bags/Adventure guide-boss loot list/Mounts tab/Heirlooms tab, and so on. However some of them are still working, like Action bar spells, Talent panel spells and maybe more.

I got only this lua error related to idTip so far:

1x Interface/AddOns/idTip/idTip.lua:203: hooksecurefunc(): SetTooltipRecipeResultItem is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@Interface/AddOns/idTip/idTip.lua"]:203: in main chunk

Locals:
ItsJustMeChris commented 2 years ago

82

ItsJustMeChris commented 2 years ago

https://github.com/silverwind/idTip/issues/82#issuecomment-1278586483

silverwind commented 1 year ago

Should all be fixed now.