search

silverwind / updates

Flexible npm and poetry dependency update tool
99 stars 8 forks source link

Fails with github package registry #25

Closed aparajita closed 5 years ago

aparajita commented 5 years ago

When the package registry is https://npm.pkg.github.com, it's failing at line 246. It seems the github registry does not support the same API as npm.

silverwind commented 5 years ago

I'm having a hard time getting any JSON response from their API. I just signed up for the beta, maybe I need to wait to be able to access the API? Does below command give you a different result, assuming you're in the beta?


$ curl -sH "Accept: application/json" "https://npm.pkg.github.com/@codertocat%2fhello-world-npm"
Not Found%
silverwind commented 5 years ago

Actually, just got it working when sending a auth token, investigating.

silverwind commented 5 years ago

Should be fixed with updates@8.1.2.

silverwind commented 5 years ago

@aparajita please confirm if possible. I'm only 90% sure I implemented it correctly.

aparajita commented 5 years ago

Works like a charm, I and the countless others who will be using the github registry thank you!