search

silverwind / updates

Flexible npm and poetry dependency update tool
99 stars 8 forks source link

request module should be a peerDependency #3

Closed NetOpWibby closed 6 years ago

NetOpWibby commented 6 years ago

^ title

silverwind commented 6 years ago

I disagree. peerDependencies are meant for plugin-style relation between packages, which I just don't see here. If you use request in you project that uses updates, you should use your own version of request.

NetOpWibby commented 6 years ago

From the request-promise-native repo:

request is defined as a peer-dependency and thus has to be installed separately.

🤷🏾‍♂️

silverwind commented 6 years ago

It's a peer dependency to request-promise-native, not to consumers. But I think I may switch to another HTTP library to avoid headaches like this :)

NetOpWibby commented 6 years ago

Alright, I’ll close this then.

silverwind commented 6 years ago

At least you made me explore other options and I found a faster http library in turn :)

NetOpWibby commented 6 years ago

Oh wow! Never heard of that package. Looks like I'll be using it too, haha!

silverwind commented 6 years ago

It's what npm uses internally, pretty nice and supports proxies too (which is a requirement for me).