search

silverwind / updates

Flexible npm and poetry dependency update tool
99 stars 8 forks source link

remove unused variables #36

Closed fisker closed 4 years ago

fisker commented 4 years ago

remove unused variables.

BTW: those tests are difficult to update, why not use snap?

silverwind commented 4 years ago

Is this an issue somewhere? I prefer to keep these destructuring variables visible for future reference and I've set up eslint to specifically ignore them if they start with a underscore:

no-unused-vars: [2, {args: all, argsIgnorePattern: ^_, varsIgnorePattern: ^_, ignoreRestSiblings: false}]
fisker commented 4 years ago

no issue, I thought that was mistaken.

closing it , since you prefer keep them

silverwind commented 4 years ago

NP. Regarding tests: Yes they are a pain as they test against the real npm. Some kind of registry mock would be nice to have.