silvia-odwyer / lightbox.js

An all-in-one, responsive React lightbox
https://getlightboxjs.com
GNU General Public License v3.0
45 stars 5 forks source link

Outdated React version warning #38

Open andreisocaciu opened 1 year ago

andreisocaciu commented 1 year ago

When I do a npm i I get all these warnings:

npm WARN While resolving: react-key-handler@1.2.0-beta.3
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   react@"18.2.0" from the root project
npm WARN   57 more (@emotion/react, @emotion/styled, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.2.0-0" from react-key-handler@1.2.0-beta.3
npm WARN node_modules/lightbox.js-react/node_modules/react-key-handler
npm WARN   react-key-handler@"^1.2.0-beta.3" from lightbox.js-react@0.9.2
npm WARN   node_modules/lightbox.js-react
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.2.0-0" from react-key-handler@1.2.0-beta.3
npm WARN   node_modules/lightbox.js-react/node_modules/react-key-handler
npm WARN     react-key-handler@"^1.2.0-beta.3" from lightbox.js-react@0.9.2
npm WARN     node_modules/lightbox.js-react
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-magnifier@3.0.4
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   react@"18.2.0" from the root project
npm WARN   57 more (@emotion/react, @emotion/styled, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.0.0" from react-magnifier@3.0.4
npm WARN node_modules/lightbox.js-react/node_modules/react-magnifier
npm WARN   react-magnifier@"^3.0.4" from lightbox.js-react@0.9.2
npm WARN   node_modules/lightbox.js-react
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.0.0" from react-magnifier@3.0.4
npm WARN   node_modules/lightbox.js-react/node_modules/react-magnifier
npm WARN     react-magnifier@"^3.0.4" from lightbox.js-react@0.9.2
npm WARN     node_modules/lightbox.js-react

Some of the dependencies have a peer dependency requirement of React version 16, and the latest is 18.

andreisocaciu commented 1 year ago

For react-key-handler there is an issue already open: 21

silvia-odwyer commented 1 year ago

@andreisocaciu Hi Andrei, Thanks for opening this issue. I'll look into updating the two dependencies with alternatives that support React 18, so that the warnings will be removed. ✅

jnorris-cencal commented 9 months ago

@silvia-odwyer any update on these warnings? Thanks!

KaivG commented 9 months ago

@silvia-odwyer just also bought a license and encountered this warning. Any update in sight?

silvia-odwyer commented 8 months ago

This is next in the development plans; I will begin working on it, so that these warnings will no longer appear in the console ✅

andreisocaciu commented 22 hours ago

Any updates? 😀