search

silvia-odwyer / photon

⚡ Rust/WebAssembly image processing library
https://silvia-odwyer.github.io/photon
Apache License 2.0
2.72k stars 154 forks source link

#145 - Some convolution filters are not working #161

Closed xweskingx closed 1 year ago

xweskingx commented 1 year ago

Applying some of these convolution filters to a fully opaque image will set the alpha channel to full transparent, as described here: https://stackoverflow.com/a/70429242

With this approach, when the image would be rendered fully transparent (all alpha values are 0), restore the alpha to the original value.

silvia-odwyer commented 1 year ago

@xweskingx Hi Wesley, Thanks very much for implementing the fix for those filters, it's greatly appreciated! 😄 I'm just wondering if you could run cargo fmt on the directory so that the test will pass, and I will then merge your contribution ✅

silvia-odwyer commented 1 year ago

@xweskingx Thanks very much for making those updates, I'm going to merge this now ✅

I really appreciate this bug fix, thanks again! 🎉