https://github.com/silviatofana/Capstone-JavaScript-/projects/1

[silviatofana]

https://github.com/silviatofana/Capstone-JavaScript-/projects/1

[Abdo9826]

set up capstone Js as a team

[mikethreels]

Hi team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

• [ ] it is good that you both commented on the issue, however, I advise you to put the number of team members in the comments to avoid misunderstandings.
• [ ] every card should be assigned to a team member which will look something like the following example.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[silviatofana]

did you see the reviewer ask for 1:02 https://microverse-students.slack.com/archives/C03L9788E9Y/p1655719330434819 I think you need to do again the cards with yours name on and detele those are done by myself but with your name on like student b

În lun., 20 iun. 2022 la 11:26, Abdelrahman Mohamed < @.***> a scris:

set up capstone Js as a team

— Reply to this email directly, view it on GitHub https://github.com/silviatofana/Capstone-JavaScript-/issues/21#issuecomment-1160133278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX4XYWNOXQFVYP74YKZH34DVQATL5ANCNFSM5ZEQMN5A . You are receiving this because you authored the thread.Message ID: @.***>

[silviatofana]

@mikethreels thanks for helpful advice please check again my partner redo the cards with his task need to do in the project

[dasileker]

Hi @silviatofana,

Great work on making the changes 👏

You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Suggested changes

Check the comments under the review.

• Please, as the previous CR said, the cards should be attributed to the team and we should see the student's Icon on that card.

• Your card

• Wanted cards look like

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

[silviatofana]

ok, thanks for helpful advice

[Lameck1]

Hi, Team,

You've done well working on the concerns from the previous reviews 👏🏼, Your Kanban board is now properly set 💯.

Highlights:

• You've properly assigned yourselves tasks ✔️
• Task distribution is fair ✔️

All the best with the next project.

You are free to merge this branch :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[silviatofana]

wow thanks God finally