Do not overwrite user set EXTRAOPTIONS

silvio / docker-languagetool

Dockerfile for LanguageTool

Other

169 stars 46 forks source link

Do not overwrite user set EXTRAOPTIONS #34

Closed someone-stole-my-name closed 2 years ago

someone-stole-my-name commented 2 years ago

Currently, it is not possible to set custom parameters.

silvio commented 2 years ago

:smile:

Okay, good that you have cancelled this pull request. But at least commit 48edde592509a99bc8eef637ae832edefd1b43fd and d7ebc6833cc578c4e8c8af2838c880ab899ddf31 could help the #32 !

someone-stole-my-name commented 2 years ago

Hi @silvio, I instead decided to do a whole refactor to:

add auto ngram download support
fix jvm options
host on ghcr
use a platform-agnostic pipeline
setup daily autobuilds based on latest upstream image

Let me know if you are interested in maintaining those changes here, honestly I just wanted a container to use in my helm chart, and yours seemed like the best option.