silviolleite / django-pwa

Looks like an app, feels like an app, but IS NOT an app.
MIT License
541 stars 112 forks source link

add the urls.py to releases #93

Closed ThePiloot00 closed 1 year ago

ThePiloot00 commented 1 year ago

Can the pwa/urls.py form the main branch be added to a release? There are errors because of the old modal used in the current release "url" that no longer sported by django 4.1.3

the error:

 File "/home/jordi/.local/lib/python3.10/site-packages/pwa/urls.py", line 1, in <module>
    from django.conf.urls import re_path
ImportError: cannot import name 're_path' from 'django.conf.urls' (/home/jordi/.local/lib/python3.10/site-packages/django/conf/urls/__init__.py)
/home/jordi/.local/lib/python3.10/site-packages/pwa/urls.py changed, reloading.

django (pip show django):

Name: Django
Version: 4.1.3
Summary: A high-level Python web framework that encourages rapid development and clean, pragmatic design.
Home-page: https://www.djangoproject.com/
Author: Django Software Foundation
Author-email: foundation@djangoproject.com
License: BSD-3-Clause
Location: /home/jordi/.local/lib/python3.10/site-packages
Requires: asgiref, sqlparse
Required-by: django-pwa

django-pwa (pip show django-pwa):

Name: django-pwa
Version: 1.0.10
Summary: A Django app to include a manifest.json and Service Worker instance to enable progressive web app behavior 
Home-page: http://github.com/silviolleite/django-pwa
Author: Silvio Luis
Author-email: silviolleite@gmail.com
License: MIT License
Location: /home/jordi/.local/lib/python3.10/site-packages
Requires: django
Required-by: 
hartungstenio commented 1 year ago

Hello. Will do as soon as #92 gets merged.

hartungstenio commented 1 year ago

Hello. I will close this issue. Let's focus discussions in #83