silviu20092 / mod-improved-bank

Improved bank module for AzerothCore.
MIT License
6 stars 1 forks source link

[Bug] "Deposit All Reagents" Depositing Tools #2

Closed F-Lambda closed 2 weeks ago

F-Lambda commented 3 weeks ago

Current Behaviour

As per title, pressing the "Deposit All Reagents" button deposits tools too. Items I've experienced this include:

The following fortunately do not get deposited:

Expected Behaviour

Tools should not be deposited.

Steps to reproduce the problem

Have tools from the list in inventory. Speak to ethereal banker and press Deposit all reagents.

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 0e1fb788c101+ 2024-10-05 00:12:41 +0800 (Playerbot branch) (Win64, RelWithDebInfo, Static)
Connected players: 1. Characters in world: 601.
Connection peak: 1.
Server uptime: 14 minute(s) 20 second(s)
Update time diff: 15ms. Last 500 diffs summary:
|- Mean: 112ms
|- Median: 84ms
|- Percentiles (95, 99, max): 244ms, 271ms, 294ms
Using SSL version: OpenSSL 3.3.2 3 Sep 2024 (library: OpenSSL 3.3.2 3 Sep 2024)
Using Boost version: 1.86.0
Using CMake version: 3.30.4
Using MySQL version: 80402
Found MySQL Executable: C:/Program Files/MySQL/MySQL Server 8.4/bin/mysql.exe
Compiled on: Windows 10.0.22631
Worldserver listening connections on port %hu
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in D:/AzerothCore/data/maps. Total size: 291014951 bytes
vmaps directory located in D:/AzerothCore/data/vmaps. Total size: 658130721 bytes
mmaps directory located in D:/AzerothCore/data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS
Using World DB: ACDB 335.12-dev
Using Playerbots DB Revision:
Latest LoginDatabase update: acore_cms_subscriptions.sql
Latest CharacterDatabase update: transmog.sql
Latest WorldDatabase update: zzz_item_stack_sizes.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
PlayerbotsDatabase queue size: 0
List of enabled modules:
|- ReusablePotion
|- StatBooster
|- StatBoosterReroller
|- mod-TimeIsTime
|- mod-account-achievements
|- mod-account-mounts
|- mod-ah-bot
|- mod-aoe-loot
|- mod-autobalance
|- mod-boss-announcer
|- mod-dynamic-xp
|- mod-fireworks-on-level
|- mod-improved-bank
|- mod-individual-progression
|- mod-instance-reset
|- mod-learn-spells
|- mod-leech
|- mod-no-hearthstone-cooldown
|- mod-npc-beastmaster
|- mod-npc-services
|- mod-playerbots
|- mod-pvp-titles
|- mod-rdf-expansion
|- mod-solo-lfg
|- mod-starter-guild
|- mod-transmog

Operating system

Windows 11 x64

Custom changes or Modules

No response

silviu20092 commented 3 weeks ago

This is not possible on clean AC. Do you have some sort of stack size modifiers? "Deposit all reagents" deposits all items with class = 7 (Trade Goods) or class = 3 (Gem) AND having a stack size bigger than 1. Jeweler's Kit for example has stack size = 1 so it can't possibly be deposited.