search

silviucpp / erlkaf

Erlang kafka driver based on librdkafka
MIT License
84 stars 41 forks source link

Hex package 1.1.7 failure undef erl_nif:set_log_process #16

Closed tsloughter closed 5 years ago

tsloughter commented 5 years ago

When using the hex package, version 1.1.7, it fails during init of erlkaf_logger because of undef erl_nif:set_log_process.

I look at the code for the module in the package and it seems fine.

When using the master branch as the dep in rebar3 it works fine, so seems to either be a problem with the package itself or just needs a new version published off current master.

silviucpp commented 5 years ago

Very strange.. there is no change between 1.1.6 and 1.1.7 in this are or between master..

silviucpp commented 5 years ago

Anyway I pushed a new version from master. Can you check ?

Silviu

silviucpp commented 5 years ago

@tsloughter any feedback ?

tsloughter commented 5 years ago

Hey, sorry about that, I was out some of last week and today is a day off as well so I haven't tried this yet at work. I'll do so tomorrow and let you know. Thanks

tsloughter commented 5 years ago

This is really weird... with 1.1.8 I'm getting:

===> Dependency failure: source for erlkaf does not contain a recognizable project and can not be built

I checked in the tarball and it look fine...

silviucpp commented 5 years ago

I have no idea what changed.. other than updating my rebar3 ...

tsloughter commented 5 years ago

@silviucpp I see the issue. The package has no src/erlkaf.app.src file somehow.

tsloughter commented 5 years ago

What rebar3_hex version are you using? Could have been a bug in there.

silviucpp commented 5 years ago

Good catch!

Check 1.1.9 I added the "src/*.src" files. Was never there but probably the old rebar3 I used automatically included this file without being into the files list.

Now it's ok ?

silviucpp commented 5 years ago

@tsloughter please confirm that problem was fixed so I can close this issue.

Thanks Silviu

tsloughter commented 5 years ago

Oops, sorry, yes, it works. Thanks!