silviucpp / erlkaf

Erlang kafka driver based on librdkafka
MIT License
84 stars 41 forks source link

jsone v1.4.5 dependency and OTP21 - compile error #3

Closed trajakovic closed 6 years ago

trajakovic commented 6 years ago

Greetings,

we have problems with erlkaf dependency jsone v1.4.5 on OTP21 in our elixir project. I know that this is pure erlang implementation, but it works great with our elixir projects until elixir 1.7.x which runs on OTP21.

When run mix compile, we're getting error:

mix compile                                                                                 ✔  10073  19:12:35
===> Compiling jsone
===> Compiling src/jsone.erl failed
src/jsone.erl:297: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
src/jsone.erl:346: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace

** (Mix) Could not compile dependency :jsone, "/Users/trajakovic/.mix/rebar3 bare compile --paths "/Users/trajakovic/IdeaProjects/scorealarm/pretty-kafka-client/_build/dev/lib/*/ebin"" command failed. You can recompile this dependency with "mix deps.compile jsone", update it with "mix deps.update jsone" or clean it with "mix deps.clean jsone"

Simplest solution to this is use jsone tag 1.4.7, so we're wondering if it's possible to update dependency directly in erlkaf project?

Thank you

silviucpp commented 6 years ago

Hello, Please send a pull request. I'll be happy to merge it

Silviu