search

silviucpp / erlkaf

Erlang kafka driver based on librdkafka
MIT License
83 stars 41 forks source link

Consumer queue cleanup #52

Closed hikui closed 1 year ago

hikui commented 1 year ago

I moved consumer_queue_cleanup calls to the consumer_group level so that the function can always be called when partitions are revoked.

This may have fixed issue #47

silviucpp commented 1 year ago

Hello, I'll review it this days ! The change fixed your problem ?

hikui commented 1 year ago

Yea, I deployed the code to our server this week and it looks good so far. I'll keep monitoring.

silviucpp commented 1 year ago

@hikui the change you did seems correct to me . Please come up with some feedback in 1 week if all good on your side as well after running in production a longer time.

If all good I'm happy to merge.

hikui commented 1 year ago

hi @silviucpp,

We've been monitoring our server for two weeks and it looks all good for us.