search

silviucpp / erlkaf

Erlang kafka driver based on librdkafka
MIT License
84 stars 41 forks source link

use OTP logger on OTP-21+ #9

Closed tsloughter closed 5 years ago

tsloughter commented 5 years ago

As mentioned in my other PR, we have Elixir apps to use this as well.

I'd have suggested moving to logger anyway but since Elixir and OTP logger play well together and I don't think it plays well with lager I figured I'd go ahead and make this PR now.

silviucpp commented 5 years ago

Merged

tsloughter commented 3 years ago

Why was this reverted? https://github.com/silviucpp/erlkaf/commit/b32cab4044c9fc3a7568a2e90e653f2a6079967e

escobera commented 3 years ago

@silviucpp I'm having trouble with lager + elixir + phoenix here as well. Am curious as well why was this reverted.

tsloughter commented 3 years ago

Yea, I can work on a new PR if I knew what needed to be done different.

silviucpp commented 2 years ago

@escobera @tsloughter Please see this thread https://github.com/silviucpp/erlkaf/issues/11#issuecomment-482582711 . I faced some issues with this change and at that point @tsloughter told me that what I want is not supported ...

I have no idea if something changed

silviucpp commented 2 years ago

Sorry because I missed your comments ..I'm watching too many repos and all the emails comes in the same directory...

tsloughter commented 2 years ago

Ah, right, the graylog from lager thing.

I doubt it is supported still, as far as I know not much work has been done on lager in the last few years.

You may want to open an issue with https://github.com/erlang-lager/lager

@silviucpp have you just had no other deps on your projects that use OTP logger that this hasn't been an issue for you? I have a feeling, unless someone outside of the lager team steps up to do the work, that your stuff moving to OTP logger (allowing erlkaf to do so as well) will happen before lager has the needed features.

silviucpp commented 2 years ago

@tsloughter One idea will be to just read the logging library from an env variable ?

silviucpp commented 1 year ago

Finally we are no longer linked to lager into our production. In the last master (publish a release soon) the library migrated to logger.