Upgrade extension to JupyterLab 4

silx-kit / jupyterlab-h5web

A JupyterLab extension to explore and visualize HDF5 file contents. Based on https://github.com/silx-kit/h5web.

MIT License

65 stars 8 forks source link

Upgrade extension to JupyterLab 4 #120

Closed mahendrapaipuri closed 1 year ago

mahendrapaipuri commented 1 year ago

Hello,

This PR focuses on upgrading build, run time dependencies to JupyterLab 4. Following changes are made:

Build time dep is bumped to JupyterLab 4 and Jupyter Server 2
Min Python version is bumped to 3.8 inline with JupyterLab 4
Node deps are bumped to JupyterLab 4, Lumino 2 and React 18
Minor changes are made in frontend extension to account for changes in JupyterLab 4
CI build workflow now uses jupyterlab maintainer tools to setup build env

Closes #116

loichuder commented 1 year ago

Wow, thanks for the PR :heart: It looks great !

Unfortunately, there appear to be some peer deps issues in the build of the CI :disappointed: It would great if you can take a look to see if you can reproduce it.

In any case, I will test it myself later this week.

mahendrapaipuri commented 1 year ago

@loichuder Cheers, happy to contribute. I tried to fix all the potential issues in CI. Should be good to go.

mahendrapaipuri commented 1 year ago

Btw, hatch is the recommended build system by project Jupyter to build extensions and they have created a plugin for building extensions. Here is a reference.

Are you keen in migrating to this build system? It is pretty neat and avoid custom logic in setup.py.

loichuder commented 1 year ago

Btw, hatch is the recommended build system by project Jupyter to build extensions and they have created a plugin for building extensions. Here is a reference.

Are you keen in migrating to this build system? It is pretty neat and avoid custom logic in setup.py.

hatch looks indeed seducing. I had a quick experience with it in another project: I encountered some problems and could not find much support online. I guess the project is still a bit young ?

Personally, I would prefer to wait a bit to see how hatch fares in the near future. But if you think you can make it work, then I'll welcome another PR.

mahendrapaipuri commented 1 year ago

Yes, it is quite a young project and I had difficulties with it too. I had to dig into source code as there is not a lot of support.

I have already done it for quite some of our custom extensions. I will put up a PR when I have some time and then you can choose to look into it when you are more comfortable working with it!!