Use React 18 renderer and fix empty cell bug

silx-kit / jupyterlab-h5web

A JupyterLab extension to explore and visualize HDF5 file contents. Based on https://github.com/silx-kit/h5web.

MIT License

64 stars 8 forks source link

Use React 18 renderer and fix empty cell bug #138

Closed axelboc closed 3 months ago

axelboc commented 3 months ago

Issue

Render H5Web in a cell
Save the notebook
Reload or re-open the notebook

Fix

The TwoRenderApp was supposed to fix this empty-cell bug, but it wasn't robust to fix the reload use case above. I'm replacing it with a solution that consists in waiting until the cell has non-empty dimensions before rendering H5Web.