silx-kit / jupyterlab-h5web

A JupyterLab extension to explore and visualize HDF5 file contents. Based on https://github.com/silx-kit/h5web.
MIT License
65 stars 8 forks source link

Document resize in README and tune H5Web cell height #93

Closed loichuder closed 2 years ago

loichuder commented 2 years ago

Fix #91

Should we do something else ? Bump the default height ?

axelboc commented 2 years ago

Here is an idea:

aspect-ratio: 16 / 10;
min-height: 500px;
max-height: 75vh;

We get everything:

I'm suggesting 75vh instead of 80vh, to allow for the code cell above the viewer to remain somewhat visible. I feel that it's important to keep the path of the file that is being viewed on the screen. Also, I think it's important to keep enough space above/below the viewer for people who configure their mouse wheel to jump more lines than usual on scroll. You don't want them to have to scroll back and forth or drag the scrollbar to move the viewer in the middle of the viewport...