search

silx-kit / pyFAI

Fast Azimuthal Integration in Python
Other
107 stars 96 forks source link

pyFAI geometry and the 3D view #1107

Open picca opened 5 years ago

picca commented 5 years ago

Hello, we are trying to define the Cirpad using the 3D view.

BUT, looking at the documentation, there d1, d2, d3, x1, x2, x3, (x, y, z in the comments of the code), and x, y, z, from the OpenGl view. (when doing translations) It is not clear to us, which axis correpond to which axis in the geometry of pyFAI.

Is it possible to stick to one definition and only one :) I do not know which one your prefer and use it everywhere even in the OpenGL view.

It would be great also to name the axis in the "repère orthonormé" :)

It seems that the http://www.silx.org/doc/pyFAI/latest/geometry.html#default-geometry-in-pyfai geometry show that rot2 and rot1 are not direct relatively to x1 and x2.

Cheers

Frederic and Alexandre

picca commented 5 years ago

Looking at the documentation in the pyFAI-calib2 the 2D view has X and Y axis but it seems that they are exchanged, if we read correctly the previous documentation. (axis1 is the slow direction y, ans axis2 is the fast one x)