[calib2] Remove the concept of group from the picking task

[vallsv]

After a single user test, i feel that the picking is too complex.

I think it would be good to remove the concept of group, and only focus on the concept of ring (a peak is part of a ring, not part of a group with a random name).

The current state of the GUI could do the transition, as there is now enough tools to deal with that (move peak from another ring number, remove peaks).

The simplification could be done by:

• Remove group name from the table
• Sort rings by number
• Rework the way to edit the ring number (maybe no need to display all the time a spinbox)
• Rework the peak modelization (part of the API will not be needed any more)

Could look like something like that:

[jangarrevoet]

Hi Valentin, maybe when you are reworking this, I have very spotted data so it only recognises 1 pixel at each click during the peak picking. If I now want to select multiple peak on 1 ring I each time have to change the ring number since it is automatically incrementing. Maybe there is already a solution for this, if not I would propose to add a check box to enable disable the auto ring index increment. If auto increment is disabled, a spinbox shows the default ring value for the new picked points. If not related but valid and you don't want to merge these enhancements, I can also open a separate one. greetings, Jan

[vallsv]

Hi, yes @jangarrevoet, it was really needed to fix calibration with noise images. On the PR #1183 now you can edit a ring, and disable the auto-increment. Feel free to test it if you like.

[vallsv]

Oh, and we plan to do a release at the end of April.