search

silx-kit / silx

silx toolkit
http://www.silx.org/doc/silx/latest/
MIT License
119 stars 70 forks source link

make match ratio configurable in opencl/sift #4099

Closed ChannyClaus closed 2 months ago

ChannyClaus commented 3 months ago

resolves https://github.com/silx-kit/silx/issues/4098

allows the users to configure match ratio via the environment variable SILX_SIFT_MATCH_RATIO. should be a pretty low-risk + perfectly backwards compatible change.

kif commented 2 months ago

One should document this new environment variable ... beside this, the code LGTM

t20100 commented 2 months ago

An environment variable doesn't seems to be needed here.

Since silx.opencl.sift.param.par is a dict, it is possible to change the value programmatically:

import silx.opencl.sift.param

silx.opencl.sift.param.par["MatchRatio"] = 0.5
ChannyClaus commented 2 months ago

An environment variable doesn't seems to be needed here.

Since silx.opencl.sift.param.par is a dict, it is possible to change the value programmatically:

import silx.opencl.sift.param

silx.opencl.sift.param.par["MatchRatio"] = 0.5

ahh darn great point. let me close this. thanks! should we document this?

t20100 commented 2 months ago

should we document this?

Yes, Pull Request welcomed!