sim0n00ps / OF-DL

C# console app to download all of the media from Onlyfans accounts with DRM video downloading support
717 stars 64 forks source link

Object reference not set to an instance of an object. #523

Closed ZincStoat closed 2 weeks ago

ZincStoat commented 1 month ago

Using 1.7.71. Updated auth.json using the plugin. Downloads from individual creators seem fine, but Download Purchased Tab breaks with the following: image

Last few lines of the log with LoggingLevel set to "Debug" read

` 2024-08-14 19:19:27.661 +01:00 [DBG] Calling BuildHttpRequestMessage 2024-08-14 19:19:27.661 +01:00 [DBG] Calling GetDynamicHeaders 2024-08-14 19:19:27.661 +01:00 [DBG] Path: /api2/v2/users/list?x[]=17432550 2024-08-14 19:19:27.661 +01:00 [DBG] Query Params: ? 2024-08-14 19:19:27.662 +01:00 [DBG] Full request URL: https://onlyfans.com/api2/v2/users/list?x[]=17432550? 2024-08-14 19:19:27.900 +01:00 [ERR] Exception caught: Object reference not set to an instance of an object.

StackTrace: at OF_DL.Helpers.APIHelper.GetPurchasedTabUsers(String endpoint, IDownloadConfig config, Dictionary`2 users) 2024-08-14 19:19:27.904 +01:00 [ERR] Exception caught: Object reference not set to an instance of an object.

StackTrace: at OF_DL.Program.DownloadAllData(APIHelper m_ApiHelper, Auth Auth, Config Config) at OF_DL.Program.Main(String[] args) `

Not sure where it's going wrong, but one error breaks the whole download, which is not ideal.

22none commented 1 month ago

image

Getting a similar issue but not just for purchased tabs. I also scrapped this user yesterday with no issues. Today there were no new posts or messages so I'm guessing OF changed something with their posts.

esaurus commented 1 month ago

Having this issue also today. Last week worked ok. Using latest version 1.7.7.1.

fidelio959 commented 1 month ago

Same problem for me for messages using latest version. Any news?

melithine commented 1 month ago

Looks like onlyfans changed something. We'll have to look into it and make a new release.

Wingzer01 commented 1 month ago

Normal posts are downloaded without any problems Only message posts display the corresponding error message

Exception caught: Object reference not set to an instance of an object.

StackTrace: at OF_DL.Helpers.APIHelper.GetPaidMessage(String endpoint, String folder, IDownloadConfig config)

melithine commented 1 month ago

It's not just messages and not just the purchased tab. Videos seem fine but scraping a single post with just images failed when I was testing.

sim0n00ps commented 1 month ago

Its because they changed the JSON responses slightly, I'm working on a fix please be patient

djmarioka commented 1 month ago

Its because they changed the JSON responses slightly, I'm working on a fix please be patient

Thanks a lot :)

bezaaas commented 1 month ago

Its because they changed the JSON responses slightly, I'm working on a fix please be patient

Do you have any news? 🙏

sim0n00ps commented 1 month ago

I've fixed the problem and need to iron out a few things, then it will be ready for release later today hopefully

Astercholik commented 1 month ago

Any news on whether a fix will be released today?

sim0n00ps commented 1 month ago

https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.72

ZincStoat commented 4 weeks ago

I've been away for a few days, and got back to find this issue closed. I've updated to 1.7.73 though and I'm getting the exact same results I quoted when I submitted the report.

AnthonySteer commented 4 weeks ago

I've been away for a few days, and got back to find this issue closed. I've updated to 1.7.73 though and I'm getting the exact same results I quoted when I submitted the report.

I have updated to 1.7.72 and, for me, the fix is working. Maybe two different causes with the same manifestation? I think this fix fixed the general issue of Object reference not set to an instance of an object which started happening yesterday regardless of which part of the site was being downloaded, but your issue was more specific to purchased.

melithine commented 4 weeks ago

I've been away for a few days, and got back to find this issue closed. I've updated to 1.7.73 though and I'm getting the exact same results I quoted when I submitted the report.

Reopened. Can you please provide a fresh debug log, the whole thing? Seems like your issue may have been separate than the one that was affecting everyone else, despite literally having the exact same error message. I tried my purchased tab and it was without issue.

ZincStoat commented 4 weeks ago

Here y'go. OFDL20240822.zip

djmarioka commented 4 weeks ago

Hi, the new update looks like it doesn't work.

Could anybody fix it?.

Thanks.

melithine commented 4 weeks ago

Hi, the new update looks like it doesn't work.

Could anybody fix it?.

Thanks.

If you have the exact same issue as before, please attach a debug log. Otherwise please file a new issue with details beyond "doesn't work".

fidelio959 commented 4 weeks ago

With the version 1.7.73 I can scrape free posts and messages even with DRM but not single post or purchased ones.

sim0n00ps commented 4 weeks ago

If you can try https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.74 and let me know if that fixes it. It should fix the null ref issue that most people will be seeing, I'll leave this issue open for now

ZincStoat commented 4 weeks ago

If you can try https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.74 and let me know if that fixes it. It should fix the null ref issue that most people will be seeing, I'll leave this issue open for now

Same result I'm afraid. I'm guessing it's barfing on just one file and/or creator, and that's causing the whole Purchased Tab scan to abort. Latest debug log attached. Thanks for looking into this.

OFDL20240823.zip

CaptainKoons commented 4 weeks ago

If you can try https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.74 and let me know if that fixes it. It should fix the null ref issue that most people will be seeing, I'll leave this issue open for now

I've tried V1.7.74 on 6 creators. Works perfect for me. Many thanks!

Wingzer01 commented 4 weeks ago

If you can try https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.74 and let me know if that fixes it. It should fix the null ref issue that most people will be seeing, I'll leave this issue open for now

It's going well

sim0n00ps commented 4 weeks ago

If you can try https://github.com/sim0n00ps/OF-DL/releases/tag/OFDLV1.7.74 and let me know if that fixes it. It should fix the null ref issue that most people will be seeing, I'll leave this issue open for now

Same result I'm afraid. I'm guessing it's barfing on just one file and/or creator, and that's causing the whole Purchased Tab scan to abort. Latest debug log attached. Thanks for looking into this.

OFDL20240823.zip

Alright I think the only way I'm going to be able to reproduce this is with your actual Auth because I can't reproduce it on my account and it seems others don't have the same issue. Probably best to contact me on discord if you have it

fidelio959 commented 4 weeks ago

I tried the latest version and is working fine. I can download single posts and full scrape. Thanks for your great work!!