sim0n00ps / OF-DL

C# console app to download all of the media from Onlyfans accounts with DRM video downloading support
846 stars 70 forks source link

Downloaded filenames are incorrect and include the DownloadPath from the config #549

Closed hydr0homiee closed 1 month ago

hydr0homiee commented 2 months ago

I downloaded the newest version and my downloaded files seem to be {downloadpath}{whatever_nameformat} instead of just the name format I choose.

If my config looks like this:

  "DownloadPath": "Y:\\Onlyfans_Rips\\_OF_DF\\",
  "PaidPostFileNameFormat": "{username}_{mediaCreatedAt}_{filename}",
  "PostFileNameFormat": "{username}_{mediaCreatedAt}_{filename}",
  "PaidMessageFileNameFormat": "{username}_{mediaCreatedAt}_{filename}",
  "MessageFileNameFormat": "{username}_{mediaCreatedAt}_{filename}",

The downloaded file ends up in a folder at the specified DownloadPath with a name like YOnlyfans_Rips_OF_DLusernamehere_2024-09-03_filenamehere.jpg or something

melithine commented 2 months ago

That's strange. I use the following with no trouble:

  "DownloadPath": "/data/",
  "PaidPostFileNameFormat": "{username} - PPV Post - {mediaCreatedAt}_{id}_{mediaid}",
  "PostFileNameFormat": "{username} - Post - {mediaCreatedAt}_{id}_{mediaid}",
  "PaidMessageFileNameFormat": "{username} - PPV Message - {mediaCreatedAt}_{id}_{mediaid}",
  "MessageFileNameFormat": "{username} - Message - {mediaCreatedAt}_{id}_{mediaid}",

(I run it under Docker, thus why I have it storing in /data/.)

I think we'll need a debug log to troubleshoot this, I can't see why your config isn't working correctly off the cuff.

hydr0homiee commented 2 months ago

Here are the debug logs.

OFDL20240903.txt

FarmingCrops commented 2 months ago

file names im getting is {mediacreatedAt} 0ht45ej42dcoyxqvbi5cc_source instead of 2024-08-08 0hsg8bz79skhkn6980pa5_source

"PaidPostFileNameFormat": "{} {}", "PostFileNameFormat": "{mediacreatedAt} {filename}", "PaidMessageFileNameFormat": "{mediaCreatedAt} {filename}", "MessageFileNameFormat": "{mediaCreatedAt} {filename}", "RenameExistingFilesWhenCustomFormatIsSelected": true,

hydr0homiee commented 2 months ago

This issue still persists for me on 1.7.76 as well.

Quildar commented 2 months ago

Same issue running 1.7.76 on Windows

hydr0homiee commented 1 month ago

Not sure if any changes were made but this seems fixed as of 1.7.79!

hydr0homiee commented 1 month ago

Though I am now noticing the RenameExistingFilesWhenCustomFormatIsSelected option seems to be broken, not sure if it was always broken or not.

melithine commented 1 month ago

Though I am now noticing the RenameExistingFilesWhenCustomFormatIsSelected option seems to be broken, not sure if it was always broken or not.

There's a bug on that already, #345