search

sim0n00ps / OF-DL

C# console app to download all of the media from Onlyfans accounts with DRM video downloading support
828 stars 69 forks source link

RenameExistingFilesWhenCustomFormatIsSelected does not work with drm protected post videos #568

Closed michamisch closed 1 month ago

michamisch commented 1 month ago

Some files did not get renamed on my Windows System especially files starting with 0 in the name. After some looking around in the code (DownloadHelper.cs) I found out that the strings are constructed like this: string fullPathWithTheServerFileName = $“{folder}{path}/{serverFilename}{extension}”; The path will then be converted to windows \0 wich is a null terminator in my case. This in turn causes the File.Exists call to fail. My C# coding skills are unfortunately too bad, otherwise I would have fixed this myself

Edit: First i though this is a \0 problems, but after looking at the source code i found that the logic for renaming drm videos is missing

sim0n00ps commented 1 month ago

If you know what needs to be changed then create a Pull Request and I'll merge it

melithine commented 1 month ago

This is a duplicate of #345, please continue there.