search

sim51 / logisima-play-cas

CAS authentification module (SSO)
http://www.bsimard.com
19 stars 8 forks source link

Java illegal String check #15

Closed fnicollet closed 10 years ago

fnicollet commented 10 years ago

Hi,

In the code, you have this line: https://github.com/sim51/logisima-play-cas/blob/master/app/controllers/modules/cas/SecureCAS.java#L59

String are compared using == instead of equals, which will fail

By the way, when you leave to another page (CAS login page, different domain), then come back to your original page, won't your session id be different? We are having trouble with the CAS module that won't redirect to the original URL because it seems it can't find the key in the cache (even after the == fix)

Thanks, Fabien

sim51 commented 10 years ago

Hi,

Thanks for your message and to point me this error. I have corrected it.

Cheers.

fnicollet commented 10 years ago

Cool, thanks

What do you think about the redirect issue with session IDs?

sim51 commented 10 years ago

I have reproduce this error with the mock server, and I have also corrected it. Can tell me if it's OK ?

fnicollet commented 10 years ago

Sure, i'll try it out tomorrow, thanks!

fnicollet commented 10 years ago

Looks like it is working correctly now, thanks !