sim51 / logisima-play-cas

CAS authentification module (SSO)
http://www.bsimard.com
19 stars 8 forks source link

using getFullUrl instead of application.url property #7

Closed sdenef closed 13 years ago

sdenef commented 13 years ago

Hi,

I notice that Play! use "application.baseUrl" (see http://www.playframework.org/documentation/1.2.1/emails) So in application.conf file "application.baseUrl" (for Play!) and "application.url" (for CAS module) are the same

In the CAS module, change CASUtils.getCasServiceUrl() /1/ use Router.getFullUrl(...) instead of "application.url" and append authenticate url /2/ or String casServiceUrl = Router.getFullUrl("/"); and append authenticate url

May be I'm wrong, I don't test it. But it will be great to not duplicate properties.

Regards, Neoh

sim51 commented 13 years ago

Yep, I will change application.url to application.baseUrl soon (tomorrow).

Thanks

sim51 commented 13 years ago

It's done !

I 've used Router.getFullUrl for default url, but if application.baseUrl (or application.baseUrl.ssl for proxycas) is specified, i use it !

Moreover, I 've added :