sim51 / logisima-play-cas

CAS authentification module (SSO)
http://www.bsimard.com
19 stars 8 forks source link

redirect back to login page broken in 3.1 #8

Closed tomnatt closed 13 years ago

tomnatt commented 13 years ago

Between 3.0 and 3.1, in SecureCAS you have moved from using the flash scope to store the application url when you get bounced to CAS to using the cache. However, you seem to still be using flash in filter() (line 160 and 161). This means that when you pull the variable out of cache (line 109) it isn't there and the app always redirects to "/".

If it helps, I fixed this locally (crudely) by copying:

if (!Router.route(request).action.equals("modules.cas.SecureCAS.login")) {
        // we put into session the url we come from
        Cache.add("url_" + session.getId(), request.method == "GET" ? request.url : "/", "10min");
}

into line 162.

Thanks for this module - it's incredibly helpful!

sim51 commented 13 years ago

It's done, but I haven't increased the version (it's again 3.1).

Thanks for your bug report and for your support !

Cheers.