sim51 / react-sigma

Sigma React component
https://sim51.github.io/react-sigma/
MIT License
172 stars 27 forks source link

Display mixed node type doesn't work #33

Closed BaherZ closed 1 year ago

BaherZ commented 1 year ago

Steps to reproduce

Expected behavior

Image nodes would show as images Regular/Circle nodes would show as circles

Actual behavior

Exactly the same error as the one reported in this ticket: https://github.com/sim51/react-sigma/issues/32#issuecomment-1282545745

Uncaught TypeError: Cannot read properties of undefined (reading 'process') at Sigma.process (sigma.js?2055:622:1) at Sigma._refresh (sigma.js?2055:698:1) at Sigma.refresh (sigma.js?2055:1191:1) Additionally, include (as appropriate) console logs, stacktraces, screenshots, and other debug info.

sim51 commented 1 year ago

I did an example that works Take a look here : https://codesandbox.io/s/react-sigma-example-qlkqg8

In fact you have to define the full list of program that you want to use (in the example circle & image), otherwise there is an issue. But in the next version of sigma (probably the 2.4) if you provide a list program, it will be merged with the default (see this commit https://github.com/jacomyal/sigma.js/commit/d318cf63c983ba8b2d613b876ccc6f84c37f5b55 )

BaherZ commented 1 year ago

Fixed, thanks, and looking forward to the next version :)