Closed GoogleCodeExporter closed 9 years ago
We are happy to accept patches if you want to work on this.
Original comment by noelgrandin
on 25 Mar 2014 at 7:52
I have attached a patch that fully supports embedding the web console in an
iframe.
The patch is tested in
* Chrome (Version 33.0.1750.149)
* Firefox (27.0.1)
* IE8
The patch replaces the references to the top frame with references to the
parent frame in the javascript code (as suggested Noel Grandin in the following
discussion https://groups.google.com/forum/#!topic/h2-database/0u3AU1b43cI).
The patch also removes some javascript from the jsp pages that runs on page
load e.g. in admin.jsp:
- <script type="text/javascript">
- <!--
- if (self != top) {
- top.location = "admin.jsp";
- }
- //-->
- </script>
Not sure what the purpose of this code is but it makes it impossible to load
the page in an iframe. This is probably some legacy code which is never used,
but correct me if I'm wrong. The svn history does not tell the story behind
this code since it is not available.
Is there something more I can do?
Original comment by anders.s...@gmail.com
on 28 Mar 2014 at 1:34
Attachments:
[deleted comment]
[deleted comment]
Attaching the a html file that can be used for testing the web console embedded
in an iframe.
Original comment by anders.s...@gmail.com
on 28 Mar 2014 at 1:39
Attachments:
Sorry this took so long.
Committed in revision 5617.
Will be available in version 1.3.177
Original comment by noelgrandin
on 17 Apr 2014 at 7:43
Original issue reported on code.google.com by
anders.s...@gmail.com
on 24 Mar 2014 at 5:44