Closed highruned closed 9 years ago
Hey Eric,
Thanks for the update. Did you have to make changes to the actual websocket-js lib? Or just update to the newer version? I have web-socket-js as a git submodule in the support folder. So if you didnt make changes we can just update the submodule reference. If you did make changes we may want to consider contributing those back to the web-socket-js project.
The change you made look perfectly reasonable. I assume some of the file Class name changes in the gitme code are from updates to that library.
Are you running this against a current version of Socket.io?
Hi Simeon!
That's right. I am running the newest web-socket-js and Socket.IO. I did not contribute to either. Those are their changes.
Sorry I forgot to disable debug mode - although it's not bad enabled by default IMO - had helpful info I spent time looking for manually.
House cleaning
Got it working with the latest web-socket-js and some minor improvements.
Not sure what to do about the added imports. I put them in the root folder of the repo in my project: https://github.com/stokegames/pomelo-flashchat/tree/master/net
Let me know and I'll correct.