simbabarry / smslib

Automatically exported from code.google.com/p/smslib
0 stars 0 forks source link

Enhance Service with simple lifecycle management. #181

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi

I think Service can be enhanced with simple lifecycle management to reduce
unnecessary synchronizations. For example, Service.sendMessage can
perfectly work without synchronization on gateways list at all. Router
maybe requires it, but that's another story.
If Service will protect gateways list from external modifications by
lifecycle management (i.e. throw exception if gateways will be added after
Service.start was invoked) and from internal modifications by contract, it
will make Service much more effective.
Bottom line: I have feeling that synchronizations should be reviewed once
again to make gateway utilization more effective. For current 3.4 it just
doesn't allow parallel sending of messages.

Thanks.

Original issue reported on code.google.com by allat...@gmail.com on 5 Feb 2009 at 10:58

GoogleCodeExporter commented 9 years ago
Hi and sorry for skipping this - it's a closed issue and I seem to have missed 
the email notification.

Hmm... I don't quite remember why I've changed back to the original queue 
design. The new one had issues, but I can't say. I must look back in history a 
bit.

As for the changes: Unfortunatelly my free time is a bit limited this last 
year. SMSLib may be ok to work with but it's certainly not considered feature 
full! It's just that I've stepped back a bit in order to settle other 
(personal) things down.

Feel free to create or comment on new issues if you wish to engage yourself! We 
can discuss this offline any time you like.

Original comment by T.Delenikas on 9 Apr 2011 at 12:43