search

simbaja / gehome

Python SDK for GE smart appliances
MIT License
42 stars 29 forks source link

- Update Remote Delay start to use timedelta via time span converter #20

Closed warrenrees closed 3 years ago

simbaja commented 3 years ago

crap, didn't see this and actually made similar updates. I just made configuration change (after looking at the PR) which was the only piece needed from what I see. during my commits, I actually changed the defaults as I noticed that the existing timespans were all 2 bytes.

I think we can abandon this PR, agree?

warrenrees commented 3 years ago

Yep, can you just update the erd_configurwtion file and point the delay control to the timespan converter?

simbaja commented 3 years ago

Yep, did that after I saw your PR :)

On Wed, Jul 21, 2021 at 3:56 PM warrenrees @.***> wrote:

Yep, can you just update the erd_configurwtion file and point the delay control to the timespan converter?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/simbaja/gehome/pull/20#issuecomment-884457587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEHFXF5JSJRG534J2MRGV3TY4Q7NANCNFSM5AXHPE4Q .

warrenrees commented 3 years ago

Have you push it up, it doesn't appear to be showing yet on my end.

simbaja commented 3 years ago

Ha, oops.

On Wed, Jul 21, 2021 at 4:02 PM warrenrees @.***> wrote:

Have you push it up, it doesn't appear to be showing yet on my end.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/simbaja/gehome/pull/20#issuecomment-884461653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEHFXHIQTSOYS56OMKE5YDTY4RW7ANCNFSM5AXHPE4Q .

warrenrees commented 3 years ago

Ahh there it is. Thanks.