search

simbaja / gehome

Python SDK for GE smart appliances
MIT License
42 stars 29 forks source link

Add erd codes and functions for ge profile hood fan/lights #27

Closed DigitalBites closed 3 years ago

DigitalBites commented 3 years ago

Per our dialog, here's the updates to add ERD codes for a GE Profile Hood Fan and Lights. The Lights have 3 states and the fan has 5... I'll work on the changes in the ha_gehome module next but this seems to run fine locally with the web socket client/script..

DigitalBites commented 3 years ago

FYI - RE #25

simbaja commented 3 years ago

Great job on figuring out how to get these added. Just a few comments/thoughts as I looked through it, let me know what you think.

DigitalBites commented 3 years ago

I just committed changes which removed the unused functions and resolved those items. I'll create a light sensor type for the light control but want to better understand the HA piece first so I'm not changing things again once I better understand how its going to be used.

simbaja commented 3 years ago

Sounds good. Looking through the known codes, it looks like there's only one other light-related code: LIGHT_BAR (not even sure what it really is and haven't configured it yet). The HA integration currently doesn't have the light platform added yet, but it should be relatively easy to do (basically creating a GeErdLight entity class and getting it all hooked up). Alternatively, we can potentially use the select platform as well (which we'll probably have to do for the fan speed setting anyway).

DigitalBites commented 3 years ago

Yeah I was looking at it yesterday (ha_gehome) and did see it was missing the light platform. I much prefer to use a light vs a select entity for usability but will end up having to do something for the dimming. I'll start working through that next week as I'm planning on being tied up this weekend.

simbaja commented 3 years ago

Sounds good. I'll see if I can get a light started and hooked in over the weekend, then we can work through dimming design. Have a good night.

simbaja commented 3 years ago

I think I've got all the hood ERD codes added, can you confirm it all works as expected here? If so, I'll start getting it implemented on the HA side. Looking through the documentation for HA, I have a couple ideas on how to make the light mode work, but still looking at it a bit.