GE Built In AC Support - Githubissues

DaveZheng commented 2 years ago

Adding appliance ERD type support for Built In GE Air conditioners with WI-FI enabled

Tested the following models:

AJCQ08AWH, AJCQ10AWH, AJCQ12AWH

AJCQ08AWHK1, AJCQ10AWHK1, AJCQ12AWHK1 https://www.geappliances.com/appliance/GE-115-Volt-Built-In-Cool-Only-Room-Air-Conditioner-AJCQ12AWH

These models were able to correctly populate existing ERD attributes below, with example values:

ErdCode.MODEL_NUMBER: AJCQ12AWHK1
ErdCode.SERIAL_NUMBER: 00000000
ErdCode.TEMPERATURE_UNIT: ErdMeasurementUnits.IMPERIAL
ErdCode.APPLIANCE_TYPE: ErdApplianceType.BUILT_IN_AIR_CONDITIONER
ErdCode.UNIT_TYPE: ErdUnitType.UNKNOWN
ErdCode.WIFI_MODULE_UPDATING: True
ErdCode.WIFI_MODULE_SW_VERSION: 0.1.11.50
ErdCode.WIFI_MODULE_SW_VERSION_AVAILABLE: 0.0.0.0
ErdCode.ACM_UPDATING: False
ErdCode.APPLIANCE_SW_VERSION: 0.0.0.0
ErdCode.APPLIANCE_SW_VERSION_AVAILABLE: 0.0.0.0
ErdCode.APPLIANCE_UPDATING: False
ErdCode.AC_TARGET_TEMPERATURE: 72
ErdCode.AC_FAN_SETTING: ErdAcFanSetting.LOW
ErdCode.AC_OPERATION_MODE: ErdAcOperationMode.ENERGY_SAVER
ErdCode.AC_AMBIENT_TEMPERATURE: 74
ErdCode.AC_FILTER_STATUS: ErdAcFilterStatus.OK
ErdCode.AC_POWER_STATUS: ErdOnOff.ON
ErdCode.SAC_AVAILABLE_MODES: ErdSacAvailableModes(has_heat=False, has_dry=True, has_eco=True, raw_value='06')
ErdCode.WAC_DEMAND_RESPONSE_POWER: 0.267
ErdCode.WAC_DEMAND_RESPONSE_STATE: ErdWacDemandResponseState.NOT_IN_DEMAND_RESPONSE

DaveZheng commented 2 years ago

Got this working on HACS by messing around with defaulting UNKNOWN devices to SAC - I can open up a separate PR once I have time to address a couple of things:

Create a new device for GE Built In AC
Create new entities for GE Built In AC (slightly differ from SAC or PAC, using it as a base)
Update serial_or_mac function to account for the fact that GE Built in air cons have a serial number of '00000000', which would result in multiple built in ACs (which I have in my case) resolving to 1 single device - have it so that if the serial number is the previously mentioned, default to the MAC address
Bump the dependencies in manifest to new gehomesdk version
If I have extra time, try to mess with the HASS device / entity UI so it is one cohesive control panel rather than splintered into on / off controls + climate controls, chances are home kit does not have this standard so might scrap

@simbaja let me know how this looks

simbaja commented 2 years ago

@DaveZheng, I've made the changes to the HA component in the dev branch, can you pull that down and see if I got it all?

simbaja / gehome

GE Built In AC Support #39