search

simbaja / gehome

Python SDK for GE smart appliances
MIT License
42 stars 29 forks source link

add to requirements.txt #50

Closed tcgoetz closed 1 year ago

tcgoetz commented 1 year ago

After installing with:

pip install gehomesdk

I run and get the following errors:

ModuleNotFoundError: No module named 'lxml'
...
ModuleNotFoundError: No module named 'slixmpp'

requirements.txt needs the following lines added:

lxml
slixmpp
gleepwurp commented 1 year ago

Hi @tcgoetz, with which python version are you encountering the issue?

I've just tried with python3 (3.10.6) and didn't get any issues, and dependencies got pulled...? did a pip3 install gehomesdk and it worked, no mention of lxml and slixmpp:

Installing collected packages: charset-normalizer, websockets, urllib3, multidict, idna, humanize, frozenlist, certifi, bidict, attrs, async-timeout, yarl, requests, aiosignal, aiohttp, gehomesdk

Successfully installed aiohttp-3.8.4 aiosignal-1.3.1 async-timeout-4.0.2 attrs-22.2.0 bidict-0.22.1 certifi-2022.12.7 charset-normalizer-3.0.1 frozenlist-1.3.3 gehomesdk-0.5.8 humanize-4.6.0 idna-3.4 multidict-6.0.4 requests-2.28.2 urllib3-1.26.14 websockets-10.4 yarl-1.8.2
tcgoetz commented 1 year ago

I installed gehomesdk into a fresh venv (no packages installed) and got errors when I tried to run the utility. After installing those packages manually, the utility ran fine. I would guess you installed it into a system that already had those packages installed.

I don't see either of those packages as part of the collected packages in your listing.

gleepwurp commented 1 year ago

Hi, makes sense, I just checked and you are correct, they were already installed. my bad!

simbaja commented 1 year ago

Should be done in the source, will publish a new version with the changes as well to pypi, thanks!