simbaja / gehome

Python SDK for GE smart appliances
MIT License
42 stars 29 forks source link

New Oven Modes #65

Open toxikman opened 7 months ago

toxikman commented 7 months ago

Recently installed a Fisher & Paykel oven model (OB30DPPTX1) and looks like there's some new modes like "Aero Bake", "Aero Broil" and "Air Fry" that are not yet supported. Here are the errors from Home Assistant running ha_gehome:

ERROR (MainThread) [gehomesdk.erd.converters.oven.oven_cook_mode_converter] Could not decode oven mode 94, raw value 5E016800000000000000000000

If y'all need more information, I'm happy to provide it or I can contribute to the code if you can pass along some recommendations for how to add new oven modes since I'm not familiar with this codebase, only basic Python and Home Assistant YAML.

simbaja commented 7 months ago

If you clone this repository and open with VSCode, you should be able to debug things. The class you want to look at is OvenCookModeConverter in the erd_decode function. There's probably some nuance for the F&P ovens that isn't accounted for in there. If you provide the debug logs (check the Usage section of the readme), I might be able to add them as well. I think I have the mode listed above added, but not sure what the other ones are.