search

simbaja / ha_gehome

GE Home Appliances (SmartHQ) for Home Assistant
MIT License
302 stars 71 forks source link

Does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method #233

Closed danielgoepp closed 2 months ago

danielgoepp commented 4 months ago

Looks like some changes in Home Assistant ClimateEntityFeature. I figure you all are aware of this, but I didn't see another story to track this, in case anyone else looking for a status like I was, can we have an issue here?

2024-02-10 17:21:54.403 WARNING (MainThread) [custom_components.ge_home.update_coordinator] Could not find appliance D828C949D0E0 in known device list.
2024-02-10 17:21:54.407 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.ge_home.entities.ac.ge_wac_climate.GeWacClimate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'ge_home' custom integration
2024-02-10 17:21:54.407 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.ge_home.entities.ac.ge_wac_climate.GeWacClimate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'ge_home' custom integration
2024-02-10 17:21:54.407 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.ge_home.entities.ac.ge_wac_climate.GeWacClimate'>) implements HVACMode(s): off, auto, cool, fan_only and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'ge_home' custom integration
danielgoepp commented 4 months ago

Hi @simbaja. I'm betting you have priorities other than this project :) I just want to check in on this and see if you are aware. It doesn't look urgent necessarily, but will eventually break things. Do you have any thoughts on this one? Thanks!

simbaja commented 4 months ago

Shouldn't be that hard to add, I'll try to get it into the next release

simbaja commented 2 months ago

Should be in the latest dev version, will be in the next release.