simbayippy / pe

0 stars 0 forks source link

Unable to add student with a different name #2

Open simbayippy opened 11 months ago

simbayippy commented 11 months ago

It seems that I am unable to add a new student with name that does not exist in the list already. in this case: john roeeee does not exist but im unable to add him

It seems that a student is unique based on his/her student number, but this is not told to the user in the UG, hence making it difficult to understand why another student cannot be added. The only error thrown was that "This applicant already exists in the applicant list.", would be good to include in the UG that its unique by student number.

as its a flaw that causes occasional inconvenience to some users but they can continue to use the product, im giving it a medium severity, tho it may be one of low

Screenshot 2023-11-17 at 4.18.06 PM.png

nus-se-script commented 11 months ago

Team's Response

Thank you for bringing this issue to our attention. Our team acknowledges that it should be documented in the User Guide. However, we propose categorizing it as a 'low' severity issue. This decision is based on the fact that there is no instance of the same Student Number in NUS, and any occurrence would likely result from user error, such as accidentally entering the wrong Student Number. This scenario is anticipated to be rare, given that manual input is not required with the availability of the import CSV function.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lack of important details for add command

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


There is a lack of the crucial detail where:

the unique identifier for a student is his/her student number, this was not referenced in the UG, telling the readers so would allow them to understand such a case. One may think that its the student name which is the unique identifer

Screenshot 2023-11-17 at 5.31.52 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#2505] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]