search

simbayippy / pe

0 stars 0 forks source link

Database cleared upon duplicate student numbers #8

Open simbayippy opened 11 months ago

simbayippy commented 11 months ago

After editing the JSON file such that 2 students now have the same student number, the data clears (which is okay), but no error message is shown on the GUI, only the CLI. So, a user may be confused and do not know the reason as to why their entire database has been cleared. the addition of an error message in the GUI for this would be good to indicate the reason for so

Screenshot 2023-11-17 at 4.38.46 PM.png

Screenshot 2023-11-17 at 4.38.56 PM.png

Screenshot 2023-11-17 at 4.39.43 PM.png

nus-se-script commented 11 months ago

Team's Response

Editing the JSON file isn't well-defined, and we don't expect this to be part of normal user operation. While we do mention that advanced users can directly update the JSON file, we also expect that advanced users can read the WARNING: Data file... in the console when launching the JAR file.

Also, it seems that the warning message is saying that the tafinder.json file "could not be loaded" which means that it is corrupted. This means that the tester wrongly formatted and modified the JSON file. We also have a warning that entire data file could be cleared if corrupted.

ABC3052A-C021-425C-A39E-7E7710A843F0.png

Therefore, this is out of scope for this PE.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]