search

simbilod / meshwell

GMSH wrapper, with integrated photonics focus
https://simbilod.github.io/meshwell/
GNU General Public License v3.0
22 stars 3 forks source link

Speedup turbo turbo #31

Closed HelgeGehring closed 1 year ago

HelgeGehring commented 1 year ago

Even even faster, needs even more testing

@nikosavola

nikosavola commented 1 year ago

Cool turbo turbo 🔥⏩ , I can try once I solve my other meshing problems :D

simbilod commented 1 year ago

we just have to make sure the physicals get tagged properly, we can add tests

nikosavola commented 1 year ago

With this, I currently get

/python3.10/site-packages/gmsh.py", line 8054, in cut
    raise Exception(logger.getLastError())
Exception: Intersection operation cannot be performed
HelgeGehring commented 1 year ago

Can you try the other pull-requests and main?

HelgeGehring commented 1 year ago

I could imagine that we just need to keep one of the three steps :thinking:

nikosavola commented 1 year ago

Speedup turbo does not get the error but I'm having unrelated problems so not sure yet

HelgeGehring commented 1 year ago

maybe you have a area which get's completely kicked out? maybe we just provide different options to enable different amount of speedup?

nikosavola commented 1 year ago

I fixed one of my other problems and now this seems to work as expected

HelgeGehring commented 1 year ago

Hmm, what was the error on your side? Is this implementation less stable than the current one?

nikosavola commented 1 year ago

The error was https://github.com/simbilod/meshwell/pull/31#issuecomment-1681330471 but nots sure what caused it

HelgeGehring commented 1 year ago

@simbilod @nikosavola it still works for me super fine, do we want to merge this?

simbilod commented 1 year ago

looks good for now, we can always fix problems as they arise later