search

simc / dartx

Superpowers for Dart. Collection of useful static extension methods.
https://pub.dev/packages/dartx
Apache License 2.0
1.08k stars 88 forks source link

WIP: Migrate to nnbd #120

Closed passsy closed 3 years ago

passsy commented 3 years ago

Work in progress, open for discussion.

codecov[bot] commented 3 years ago

Codecov Report

Merging #120 (2399796) into master (d8fb660) will decrease coverage by 0.14%. The diff coverage is 91.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   96.31%   96.16%   -0.15%     
==========================================
  Files          10       10              
  Lines         786      652     -134     
==========================================
- Hits          757      627     -130     
+ Misses         29       25       -4
Impacted Files Coverage Δ
lib/src/list.dart 80.48% <20.00%> (-1.34%) :arrow_down:
lib/src/string.dart 85.96% <66.66%> (+4.29%) :arrow_up:
lib/src/comparable.dart 100.00% <100.00%> (ø)
lib/src/iterable.dart 99.54% <100.00%> (+0.14%) :arrow_up:
lib/src/iterable_num.dart 100.00% <100.00%> (ø)
lib/src/num.dart 100.00% <100.00%> (ø)
lib/src/range.dart 100.00% <100.00%> (ø)
lib/src/sorted_list.dart 95.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8fb660...2399796. Read the comment docs.

TimWhiting commented 3 years ago

@leisim @passsy This migration looks good to me, the changes make sense, any idea when you will merge / publish it?