simc / dartx

Superpowers for Dart. Collection of useful static extension methods.
https://pub.dev/packages/dartx
Apache License 2.0
1.08k stars 88 forks source link

Fix `isUpperCase` and `isLowerCase` #142

Closed minhqdao closed 2 years ago

minhqdao commented 2 years ago

The behavior of isUpperCase so far is:

'1234'.isUpperCase // true
' '.isUpperCase // true
'!'.isUpperCase // true
'\n'.isUpperCase // true
'TEST'.isUpperCase // true
'TESt'.isUpperCase // false
'HEY, YOU!'.isUpperCase // true

This is being changed to:

'1234'.isUpperCase // false
' '.isUpperCase // false
'!'.isUpperCase // false
'\n'.isUpperCase // false
'TEST'.isUpperCase // true
'TESt'.isUpperCase // false
'HEY, YOU!'.isUpperCase // true

isLowerCase is also changed, respectively.

Will update readme in https://github.com/leisim/dartx/pull/141.

codecov[bot] commented 2 years ago

Codecov Report

Merging #142 (21955ed) into master (6af8524) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.72%   96.73%           
=======================================
  Files          11       11           
  Lines         763      765    +2     
=======================================
+ Hits          738      740    +2     
  Misses         25       25           
Impacted Files Coverage Δ
lib/src/string.dart 86.44% <100.00%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6af8524...21955ed. Read the comment docs.

minhqdao commented 2 years ago

@passsy

passsy commented 2 years ago

Definitly better than before 👍