simc / dartx

Superpowers for Dart. Collection of useful static extension methods.

https://pub.dev/packages/dartx

Apache License 2.0

1.08k stars 88 forks source link

feat: obtain an ordinal number of type String for any integer #153

Closed Biplab-Dutta closed 2 years ago

passsy commented 2 years ago

Interesting. Neither the intl nor the flutter maintainers feel responsible for this. I personally would add it to intl.

codecov[bot] commented 2 years ago

Codecov Report

Merging #153 (d32cae7) into master (4d3102f) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     dart-lang/intl#153      +/-   ##
==========================================
+ Coverage   97.77%   97.80%   +0.03%     
==========================================
  Files          12       13       +1     
  Lines         763      775      +12     
==========================================
+ Hits          746      758      +12     
  Misses         17       17

Impacted Files	Coverage Δ
lib/src/int.dart	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d3102f...d32cae7. Read the comment docs.

Biplab-Dutta commented 2 years ago

Interesting. Neither the intl nor the flutter maintainers feel responsible for this. I personally would add it to intl.

If you think that's a nice idea, i would then send them a PR. Thanks for your suggestion.

passsy commented 2 years ago

Try it, but I honestly don't have high hopes of it getting merged there. I'm happy to integrate it into dartx

Biplab-Dutta commented 2 years ago

I was reading some old conversations there. I am not sure of the outcome if it would get merged or rejected. Is it okay if I send them a PR and see what they have to say and if they don't like it, I'd then send you another PR with some updates in the doc too..

passsy commented 2 years ago

Sure :)

Biplab-Dutta commented 2 years ago

I think it is now good enough to get merged.

passsy commented 2 years ago

Thanks for your contribution!

Biplab-Dutta commented 2 years ago

Thanks for your contribution!

My pleasure.

oravecz commented 1 year ago

Is this en locale only? Is ordinal a concept in other locales and are they handled differently?

passsy commented 1 year ago

This method here is 'en' only. It does exist in other languages, see Ordinal indicator.

We could add a locale parameter to support more locales