simc / logger

Small, easy to use and extensible logger which prints beautiful logs.
https://pub.dev/packages/logger
MIT License
1.07k stars 129 forks source link

updated pretty printer stack trace to use error #139

Open FireAndIceFrog opened 2 years ago

FireAndIceFrog commented 2 years ago

Pretty Printer:

When passing a stack trace to Log.d it obeys the errorMethodCount instead of the methodCount when cutting the size of the stack trace.

This is not ideal because I might just want to pass in an arbitrary stack trace without making it error.

Solution:

Make the stack trace sliced via either the methodCount or errorMethodCount depending on whether the error is defined (not null)

neiljaywarner commented 2 years ago

This seems like a good idea to me.